[Tan De Jun] iP #49
[Tan De Jun] iP #49
Conversation
Amended previous Increments to resolve case "bye" printing issue
src/main/java/Duke.java
Outdated
|
|
||
| System.out.println("____________________________________________________________"); | ||
|
|
||
| if (input.equals("list")) { |
There was a problem hiding this comment.
Would it be better as a constant instead of a magic string?
There was a problem hiding this comment.
Yes, it would. Must have overlooked it thanks for pointing it out! :)
src/main/java/Duke.java
Outdated
| String input = sc.nextLine(); | ||
| String[] inputArray = input.split(" ", 2); | ||
|
|
||
| System.out.println("____________________________________________________________"); |
There was a problem hiding this comment.
Would it be better to put this in a method (for example displayLine()) instead of a magic string?
There was a problem hiding this comment.
Thats a great idea. Will implement it into my code 👍
src/main/java/Duke.java
Outdated
| public class Duke { | ||
| public static void main(String[] args) { | ||
| welcomeMessage(); |
There was a problem hiding this comment.
I think printWelcomeMessage() would be a better name than welcomeMessage() as it is a verb
There was a problem hiding this comment.
Oh you are right. It would be clearer to the user as well. Thanks!
src/main/java/Duke.java
Outdated
|
|
||
| Scanner sc = new Scanner(System.in); | ||
| List<Task> tasks = new ArrayList<Task>(); | ||
| Boolean exitProgram = false; |
There was a problem hiding this comment.
Would it be better to be called isExitCommandUsed instead of exitProgram as a boolean variable?
Merge Branch-A-JavaDoc
Merge branch-A-UserGuide into Master
No description provided.